Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_amdgpu_memory_capacity() #2049

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

HaiShaw
Copy link
Collaborator

@HaiShaw HaiShaw commented Nov 16, 2024

Motivation

Current use of get_gpu_memory_capacity() will break build for SGLang on ROCm (since v0.3.5.post2).

Modifications

Added get_amdgpu_memory_capacity(), and rename previous function to get_nvgpu_memory_capacity()

Checklist

  • [+] Format your code according to the Contributor Guide.
  • [+] Add unit tests as outlined in the Contributor Guide.
  • [+] Update documentation as needed, including docstrings or example tutorials.

Copy link
Collaborator

@ByronHsu ByronHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was it working on AMD before?

@HaiShaw
Copy link
Collaborator Author

HaiShaw commented Nov 16, 2024

Worked on v0.3.5.post1 and before, code path was different.

@ByronHsu ByronHsu merged commit 2ffe0a7 into sgl-project:main Nov 16, 2024
11 of 13 checks passed
@HaiShaw HaiShaw deleted the amdgpu-mem branch November 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants