Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Qwen2-VL-based embedding models #2055

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add support for Qwen2-VL-based embedding models #2055

merged 3 commits into from
Nov 21, 2024

Conversation

james-p-xu
Copy link
Contributor

@james-p-xu james-p-xu commented Nov 17, 2024 •
edited
Loading

Motivation

Add support for Qwen2-VL based embedding models (e.g. mcdse-2b-v1), as requested in #2032.

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@james-p-xu james-p-xu force-pushed the qwen2_vl_embedding branch 4 times, most recently from 6a599c6 to b3d7504 Compare November 18, 2024 22:53
@james-p-xu james-p-xu changed the title Add support for mcdse-2b-v1 embedding Add support for Qwen2-VL-based embedding models Nov 18, 2024
@james-p-xu james-p-xu force-pushed the qwen2_vl_embedding branch 2 times, most recently from 522815e to dc4d5f4 Compare November 18, 2024 23:59
@james-p-xu james-p-xu marked this pull request as ready for review November 19, 2024 00:26
@merrymercy merrymercy merged commit f6f7137 into sgl-project:main Nov 21, 2024
12 of 13 checks passed
@merrymercy merrymercy mentioned this pull request Nov 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-p-xu @merrymercy