Add log input text when using openai chat api #2058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccjincong
requested review from
merrymercy,
Ying1123,
hnyls2002,
zhyncs,
ispobock and
ByronHsu
as code owners
merrymercy
requested changes
Nov 17, 2024
merrymercy
requested changes
Nov 22, 2024
| if (self.text is None and self.input_ids is None) or ( | ||
| self.text is not None and self.input_ids is not None | ||
| ): | ||
| if self.text is None and self.input_ids is None: |
There was a problem hiding this comment.
I do not think you can change this. Only one of them can be provided. Otherwise, it is ambiguous.
There was a problem hiding this comment.
Does that mean in order to support this feature, I can only provide text?
But I think it conflicts with https://github.com/sgl-project/sglang/blob/fa271613809bc5d901c0e864c4f9b9d3d3a101bd/python/sglang/srt/managers/tokenizer_manager.py#L204C1-L208C38.（The encoding here does not include add_special_tokens=False.)
There was a problem hiding this comment.
you can move the logger to another place.
| stop = request.stop | ||
| image_data = None | ||
| modalities = [] | ||
|
|
||
| prompt_ids = tokenizer_manager.tokenizer.encode(prompt) |
There was a problem hiding this comment.
Add add_special_tokens=False
|
Close this for now due to inactivity. Feel free to reopen if you have any updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support the feature #1608
Modifications
Checklist