Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix assertion error for chunked prefill when disabling cache #2282

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

wangraying
Copy link
Contributor

@wangraying wangraying commented Nov 30, 2024

Motivation

When using chunked prefill with disabled radix cache, the scheduler will fail at the assertion error here.

The error is described in detail in #2255.

Modifications

This PR simply skips chunking the current request if there is already an inflight request, following the same code path as in add_one_req.

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@HaiShaw
Copy link
Collaborator

HaiShaw commented Nov 30, 2024

@wangraying thanks for the PR.

@merrymercy merrymercy merged commit d622851 into sgl-project:main Dec 1, 2024
12 of 14 checks passed
@merrymercy
Copy link
Contributor

This is probably not the correct fix. I accepted it accidentally so I reverted it in #2286.
@hnyls2002 will submit a correct fix soon.
Thanks anyway.

@wangraying wangraying deleted the fix-chunked-prefill branch December 29, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants