Eliminate 2 gpu ops during sampling when logit_bias is zero #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR: Eliminate 2 gpu ops during sampling when
logit_bias
is not used (all zeros)logit_bias
logits.add_(self.logit_bias)
On our internal test of Yi-6B quantized using
marlin
on 4090 we see tangible improvement: up to 63% throughput improvement for small sized tokens output work loads when batch > 1.Concurrency is 10 requests so it will cause sglang to use batch size between 1-10: