Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when running with full parallel #394

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

hnyls2002
Copy link
Collaborator

Why this PR?

  • Before this PR, llm_judge benchmark with parallel=64, latency=90.094, cache_hit_rate = 24%
  • After this PR, llm_judge benchmark with parallel=64, latency=53.705s, cache_hit_rate = 74%

What does this PR do?

When the priority of the waiting queue is fixed, e.g. LPM (Longest Prefix Match), the SRT should only accept a prefix of the waiting queue.

This is because we don't want the requests with lower priority to come into the prefill phase which will lead to the eviction of the previously cached prefix.

@hnyls2002 hnyls2002 merged commit 9216b10 into main Apr 25, 2024
@hnyls2002 hnyls2002 deleted the fix-schedule branch April 25, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant