-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v1/chat/completions #50
Conversation
For the chat template, can we use the hugging face tokenizer by default? https://huggingface.co/docs/transformers/main/en/chat_templating#how-do-i-use-chat-templates |
Good idea. Let me add this. |
Now if
And this template is actually incorrect for this model, so you will get the following response in the unit test:
The following response is expected with ChatML template:
Another issue is |
@@ -0,0 +1,381 @@ | |||
# Adapted from | |||
# https://github.com/lm-sys/FastChat/blob/main/fastchat/conversation.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider importing instead of copying later.
Close #26