Fix rid state map leak + Refractor .finished #505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream=False
. Rid state map cleanup code afteryield
is not executed since the receiver of the generator early returns and never calls it again. Qubitium@3407263req.finished
from a simple bool into aBaseFinishReason
object.Reason for .finished refractor:
finished_reason
state/property:output_hit_stop_str
,hit_stop_str
,finish_reason
,finished
. They are all related to the same Finished state. Having 4 separate vars separate and passing them around makes the code more complex than necessary.FinishReason.EOS
enum is now a more genericFINISH_MATCHED_TOKEN
object which now can handle any future changes where any token/tokens are matched, not just for single EOS. For example, EOT tokens in structured chat models in future code. Some existing chat models already have multiple EOS defined inmodel/config.json
. This allows the FinishReason object to hold the actual token hit instead of fixed enum which would requires anothereos_token
var in the current structure to know which of the N possible EOS token was hit.TESTS:
Tests are performed with vllm 0.4.2 since 0.4.3 requires another PR #487 :
dp == 2