Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tp worker only checking req[0] for stream #546

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

Qubitium
Copy link
Contributor

@Qubitium Qubitium commented Jun 14, 2024

One condition of early exiting the decoding batch (fixed 10 size) loop is to check if batch contains streaming requests.

Fix the current code in tp_worker which only checks the first request self.running_batch.reqs[0].stream and use a new Batch.has_stream(self) -> bool helper function to check if any batch.req has stream == true.

TESTS:

  • PASSED Mixed stream + non-stream + tp=2

@Qubitium Qubitium marked this pull request as ready for review June 14, 2024 03:50
@Ying1123 Ying1123 merged commit bbec01c into sgl-project:main Jun 15, 2024
@Qubitium Qubitium deleted the fix-tpworker-stream-check branch June 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants