Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sglang compat with vllm 0.5.1 #598

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

M0gician
Copy link
Contributor

@M0gician M0gician commented Jul 7, 2024

vLLM just updated to version 0.5.1 and its changes in Vision Language Model implementation break current SGLang from initializing any model correctly due to the removal of VisionLanguageConfig

This minimal patch at least makes vLLM happy and prevent SRT crashes. I've only tested this patch non-vision model (Qwen2) as I don't have any vision models locally.

@M0gician M0gician mentioned this pull request Jul 8, 2024
@merrymercy merrymercy merged commit b386872 into sgl-project:main Jul 9, 2024
@merrymercy
Copy link
Contributor

@M0gician It is merged. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants