Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfile and triton cache manager #720

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Fix dockerfile and triton cache manager #720

merged 3 commits into from
Jul 25, 2024

Conversation

hnyls2002
Copy link
Collaborator

@hnyls2002 hnyls2002 commented Jul 25, 2024

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

Fix #548

Modification

Add a custom cache manager.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@hnyls2002 hnyls2002 changed the title Fix docker and triton installation. Fix dockerfile and triton cache manager Jul 25, 2024
@hnyls2002
Copy link
Collaborator Author

@Ying1123 This PR temporarily fixes #548, and we do not need the triton nightly installed now.

@hnyls2002 hnyls2002 marked this pull request as draft July 25, 2024 07:45
@hnyls2002 hnyls2002 linked an issue Jul 25, 2024 that may be closed by this pull request
@hnyls2002 hnyls2002 marked this pull request as ready for review July 25, 2024 09:21
@hnyls2002 hnyls2002 requested a review from merrymercy July 25, 2024 09:21
@hnyls2002 hnyls2002 merged commit 04ec6ba into main Jul 25, 2024
2 checks passed
@hnyls2002 hnyls2002 deleted the fix-docker branch July 25, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble Shooting
2 participants