Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role documentation, add system begin & end tokens #793

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Add role documentation, add system begin & end tokens #793

merged 3 commits into from
Jul 29, 2024

Conversation

objnf-dev
Copy link
Contributor

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

Lack of documentation on how to use the role of Chat model, and lack of begin/end tokens for the System role.

Modification

Add role documentation, and system_begin(), system_end() function in api.py.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@Ying1123
Copy link
Member

please fix the lint error

@objnf-dev
Copy link
Contributor Author

Should be fixed now.

@Ying1123 Ying1123 merged commit 8f6274c into sgl-project:main Jul 29, 2024
1 check passed
@Ying1123
Copy link
Member

@objnf-dev Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants