Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code structure refactor #807

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Code structure refactor #807

merged 9 commits into from
Jul 30, 2024

Conversation

hnyls2002
Copy link
Collaborator

@hnyls2002 hnyls2002 commented Jul 29, 2024

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

To make the components of SRT more organized.

Modification

  1. Rename: manager_single, manager_multi to controller_xxx
  2. Make a module model_executor and move all model execution logic into this.
  3. (Next PR) Make a cache abstraction.
  4. (Next PR) Organize infer_batch and input_metadata, make infer_batch only for scheduling and intpu_metadata for model forward.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@hnyls2002 hnyls2002 marked this pull request as draft July 29, 2024 22:46
@hnyls2002 hnyls2002 changed the title Refactor Code structure refactor Jul 30, 2024
@hnyls2002 hnyls2002 marked this pull request as ready for review July 30, 2024 06:02
@hnyls2002 hnyls2002 merged commit cdcbde5 into main Jul 30, 2024
2 checks passed
@hnyls2002 hnyls2002 deleted the refactor branch July 30, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant