Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize public APIs #809

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Organize public APIs #809

merged 2 commits into from
Jul 29, 2024

Conversation

hnyls2002
Copy link
Collaborator

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

Organize public APIs which can be directly used by from sglang import xxx

Modification

  • Move core benchmarks into sglang/benchmarks
  • Adjust the benchmark scripts.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@hnyls2002 hnyls2002 merged commit c8e9fed into main Jul 29, 2024
2 checks passed
@hnyls2002 hnyls2002 deleted the organize-public-apis branch July 29, 2024 22:34
Ying1123 added a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant