Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update setup runner #884

Merged
merged 1 commit into from
Aug 2, 2024
Merged

docs: update setup runner #884

merged 1 commit into from
Aug 2, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Aug 2, 2024

Motivation

as titled

Modification

as titled

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@Ying1123
Copy link
Member

Ying1123 commented Aug 2, 2024

You can import the model name from a common variable

cls.backend = sgl.Runtime(model_path=MODEL_NAME_FOR_TEST)

@zhyncs
Copy link
Member Author

zhyncs commented Aug 2, 2024

ok

@zhyncs zhyncs force-pushed the upd branch 4 times, most recently from 3693f47 to ac4b15c Compare August 2, 2024 08:56
@zhyncs zhyncs changed the title test: update bind cache test docs: update setup runner Aug 2, 2024
@zhyncs
Copy link
Member Author

zhyncs commented Aug 2, 2024

You can import the model name from a common variable

cls.backend = sgl.Runtime(model_path=MODEL_NAME_FOR_TEST)

fixed in #891

@zhyncs zhyncs merged commit 7937a88 into sgl-project:main Aug 2, 2024
1 check passed
@zhyncs zhyncs deleted the upd branch August 2, 2024 11:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants