-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use FlashInfer rmsnorm and silu #907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python3 -m sglang.bench_latency --model internlm/internlm2-chat-7b --correct --output-len 16 --trust-remote-code
python3 -m sglang.bench_serving --backend sglang --num-prompts 5000
|
There is a trivial issue, let me fix it. |
Ying1123
requested changes
Aug 4, 2024
fixed |
update: python3 python/sglang/test/test_layernorm.py
|
yzh119
pushed a commit
to flashinfer-ai/flashinfer
that referenced
this pull request
Aug 4, 2024
zhyncs
force-pushed
the
upd
branch
2 times, most recently
from
August 4, 2024 08:03
93f96d0
to
c795239
Compare
Currently, e2e and unit tests are failing because |
zhyncs
force-pushed
the
upd
branch
5 times, most recently
from
August 9, 2024 12:22
f572809
to
095eb05
Compare
zhyncs
changed the title
[DO NOT MERGE] feat: use FlashInfer rmsnorm
[DO NOT MERGE] feat: use FlashInfer rmsnorm and silu
Aug 9, 2024
zhyncs
force-pushed
the
upd
branch
2 times, most recently
from
August 10, 2024 15:52
d9c6bbf
to
74c805d
Compare
zhyncs
changed the title
[DO NOT MERGE] feat: use FlashInfer rmsnorm and silu
feat: use FlashInfer rmsnorm and silu
Aug 10, 2024
Thanks so much for @yzh119's help! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
as titled cc @merrymercy @Ying1123 @hnyls2002
Wait for the FlashInfer review, PR, and new release @yzh119
https://github.com/flashinfer-ai/flashinfer/actions/runs/10330691213
Modification
fused_add_rmsnorm
andsilu_and_mul
in FlashInferChecklist
pre-commit run --all-files
or other linting tools are used to fix potential lint issues.