-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more OpenAI API test #916
Merged
Ying1123
merged 7 commits into
sgl-project:main
from
yichuan520030910320:add_openai_api_test
Aug 4, 2024
Merged
Support more OpenAI API test #916
Ying1123
merged 7 commits into
sgl-project:main
from
yichuan520030910320:add_openai_api_test
Aug 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ying1123
requested changes
Aug 4, 2024
Ying1123
requested changes
Aug 4, 2024
This was referenced Aug 4, 2024
Ying1123
requested changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.
Motivation
Support more OpenAI API tests and correspondingly make the backend more robust/ add more support
cover mostly (completion, chat_completion) x (echo, no echo) x (parallel sampling, no parallel sampling) x (stream, no stream) x (logprob, no logprob) x (single input, list input) x (str input, token id input)
Fix #910 which is caused by the conflict of PR #888 with parallel sampling and I made the backend more robust
Modification
OpenAI API test and the backend support that
Checklist
pre-commit run --all-files
or other linting tools are used to fix potential lint issues.