Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vllm to 0.5.4 #966

Merged
merged 1 commit into from
Aug 7, 2024
Merged

chore: update vllm to 0.5.4 #966

merged 1 commit into from
Aug 7, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Aug 7, 2024

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

Please explain the motivation behind this PR and the goal you aim to achieve with it.

Modification

Briefly describe the changes made in this PR.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@zhyncs zhyncs force-pushed the tmp branch 3 times, most recently from d65cd55 to ab7ee68 Compare August 7, 2024 08:53
@zhyncs zhyncs changed the title [DO NOT MERGE] chore: update vllm to 0.5.4 chore: update vllm to 0.5.4 Aug 7, 2024
@zhyncs zhyncs requested review from merrymercy, Ying1123 and hnyls2002 and removed request for merrymercy and Ying1123 August 7, 2024 09:19
@zhyncs
Copy link
Member Author

zhyncs commented Aug 7, 2024

fix

ERROR:    [Errno 99] error while attempting to bind on address ('::1', 8157, 0, 0): cannot assign requested address

@zhyncs
Copy link
Member Author

zhyncs commented Aug 7, 2024

The tolerance in test/srt/models/test_causal_models.py has been increased from 2e-2 to 3e-2 in order to pass CI, and currently both eval and benchmark meet expectations.

@zhyncs
Copy link
Member Author

zhyncs commented Aug 7, 2024

Currently, all CIs have passed, I'll merge this PR first and expect to release a new tag today. Everyone currently needs to merge the latest code from the main branch into their PRs. Thanks. cc @merrymercy @Ying1123 @hnyls2002 @yichuan520030910320 @xiezhq-hermann

@zhyncs zhyncs merged commit c31f084 into sgl-project:main Aug 7, 2024
3 checks passed
@zhyncs zhyncs deleted the tmp branch August 7, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant