Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrefillAdder abstraction #968

Merged
merged 3 commits into from
Aug 7, 2024
Merged

PrefillAdder abstraction #968

merged 3 commits into from
Aug 7, 2024

Conversation

hnyls2002
Copy link
Collaborator

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

To simplify the get_new_prefill_batch

Modification

Add a class to maintain the information of prefilling requests choice.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@hnyls2002 hnyls2002 merged commit f724f1f into main Aug 7, 2024
4 checks passed
@hnyls2002 hnyls2002 deleted the prefill-adder branch August 7, 2024 20:47
@hnyls2002 hnyls2002 mentioned this pull request Aug 8, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants