Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chunked prefill #984

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix chunked prefill #984

merged 1 commit into from
Aug 8, 2024

Conversation

hnyls2002
Copy link
Collaborator

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

When the radix cache is disabled, the chunk cache would not update the prefix indices and last node, due to the API changes in #977

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@hnyls2002 hnyls2002 enabled auto-merge (squash) August 8, 2024 05:28
@hnyls2002 hnyls2002 disabled auto-merge August 8, 2024 05:28
@hnyls2002 hnyls2002 merged commit 6ed4e3b into main Aug 8, 2024
4 checks passed
@hnyls2002 hnyls2002 deleted the fix-chunked-prefill branch August 8, 2024 05:28
@hnyls2002 hnyls2002 mentioned this pull request Aug 8, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant