Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: update test config #990

Merged
merged 1 commit into from
Aug 10, 2024
Merged

misc: update test config #990

merged 1 commit into from
Aug 10, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Aug 8, 2024

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

Please explain the motivation behind this PR and the goal you aim to achieve with it.

Modification

Briefly describe the changes made in this PR.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@zhyncs
Copy link
Member Author

zhyncs commented Aug 9, 2024

Let's hold this PR for now, until I finish configuring more runners. Then we can consider switching to this configuration. Although it will take longer, with 2 runners, the time will be overlapped.

@zhyncs zhyncs changed the title [DO NOT MERGE] misc: update e2e test config misc: update test config Aug 10, 2024
@zhyncs zhyncs merged commit e712837 into sgl-project:main Aug 10, 2024
3 checks passed
@zhyncs zhyncs deleted the tmp branch August 10, 2024 18:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant