Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add videos update #118

Merged
merged 16 commits into from
Jan 26, 2024
Merged

feature/add videos update #118

merged 16 commits into from
Jan 26, 2024

Conversation

sgobotta
Copy link
Owner


name: Pull Request
about: Add support to search for videos
title: ''
labels: ''
assignees: '@sgobotta'

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Move Sortable to a hook module
  • Add a container class attr to inputs
  • Install html entities to parse html escaped symbols
  • Remove etag requirement on videos
  • Add a function to parse videos from searches
  • Add an icon to add media to a queue
  • Change page title on sessions :show
  • Add sessions api to search videos by query
  • Handle video search to render a list of results
  • Add translations
  • Update search bar text and layout styles
  • Styles improvements to track number in the search and the queue sections
  • Confirm to exit session to navigate back to home
  • Make the add video button smaller
  • Search videos from it's own live component

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

Pull Request Test Coverage Report for Build d3a3318f7b8817b6c93f3ff1cc43215632a83d08-PR-118

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 106 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-1.4%) to 49.113%

Files with Coverage Reduction New Missed Lines %
//lib/livedj/media/video.ex 2 50.0%
//lib/livedj_web/components/list_component.ex 10 0.0%
//lib/livedj/media.ex 11 45.45%
//lib/livedj_web/components/core_components.ex 13 82.98%
//lib/livedj_web/live/player_controls_live.ex 15 0.0%
//lib/livedj/sessions.ex 16 9.43%
//lib/livedj_web/live/sessions/room_live/list.ex 39 0.0%
Totals Coverage Status
Change from base Build 81b41736a873b7076d0f9112d72d0c30c135fcc9: -1.4%
Covered Lines: 637
Relevant Lines: 1297

💛 - Coveralls

@sgobotta sgobotta merged commit 5c07009 into dev Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant