Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use editor.wordSeparators in order to classify characters. #2

Merged
merged 1 commit into from
Apr 29, 2018
Merged

Use editor.wordSeparators in order to classify characters. #2

merged 1 commit into from
Apr 29, 2018

Conversation

tekezo
Copy link
Contributor

@tekezo tekezo commented Apr 21, 2018

This change solves a problem that japanese-word-handler ignores editor.wordSeparators setting.

About an issue

The current japanese-word-handler does not check editor.wordSeparators setting in classifyChar.
Thus, the separators (e.g., underscore) are ignored.

For example, when editor.wordSeparators contains underscore (_),

editor.wordSeparators: "`~!@#$%^&*()-=+[{]}\\|;:'\",.<>/?_"

expected cursor move is:

‸classify_char
      ↓
classify‸_char

actual:

‸classify_char
      ↓
classify_char‸

About this change

This commit adds new character class Separator and classify editor.wordSeparators into Separator.

@sgryjp sgryjp self-assigned this Apr 29, 2018
@sgryjp sgryjp merged commit 8f0587d into sgryjp:master Apr 29, 2018
@sgryjp
Copy link
Owner

sgryjp commented Apr 29, 2018

I've reviewed and tested, and it worked as expected. Thank you for contributing!

@tekezo
Copy link
Contributor Author

tekezo commented Apr 29, 2018

Thank you for confirmation.
I cannot use VSCode without japanese-word-handler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants