Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple source support #1481

Merged
merged 13 commits into from
Mar 18, 2020
Merged

Add multiple source support #1481

merged 13 commits into from
Mar 18, 2020

Conversation

Harjot1Singh
Copy link
Member

@Harjot1Singh Harjot1Singh commented Mar 11, 2020 •
edited
Loading

  • Adds source support in data
  • Rename existing sources to compilations
  • Bundles source gurmukhi content in line_content table

Closes #1480

@Harjot1Singh Harjot1Singh changed the title Add variants support Add multiple publications support Mar 12, 2020
sarabveer
sarabveer suggested changes Mar 12, 2020
View reviewed changes
data/publications.json Outdated Show resolved Hide resolved
data/publications.json Outdated Show resolved Hide resolved
@sarabveer
Copy link
Collaborator

Build is going to fail, need to add support for fallback variants/publishers/publications.

@Harjot1Singh Harjot1Singh changed the title Add multiple publications support Add multiple compilation support Mar 18, 2020
@Harjot1Singh Harjot1Singh changed the title Add multiple compilation support Add multiple source support Mar 18, 2020
@Harjot1Singh
Copy link
Member Author

Benchmarks fail, since benchmarking code has not been updated/adapted. Need to figure out how to do default priority sources with override support

@Harjot1Singh Harjot1Singh changed the base branch from master to dev March 18, 2020 15:52
Harjot1Singh and others added 13 commits March 18, 2020 16:25
@Harjot1Singh
feat: add publications and line content to schema
65ea396
@Harjot1Singh
feat(data): add SGPC publication source
986893c
@Harjot1Singh
refactor(data): repurpose gurmukhi field to object containing publica…
e3bb1a0 
…tions

Related #1480
@Harjot1Singh
feat(api): add Publications model
10812e4
@Harjot1Singh
feat(api): add LineContent model and allow LineContent to be retrieve…
2d477de 
…d from Lines
@Harjot1Singh
build(data): add publications' gurmukhi to line_content table during …
d31a2dc 
…build-database
@Harjot1Singh
build(data): add publication gurmukhi content to gurmukhi object duri…
a6bbaab 
…ng build-json
@sarabveer @Harjot1Singh
fix(data): change publisher name to SGPC
37c35b4
@sarabveer @Harjot1Singh
feat(data): add Budha Dal Mehron publisher and update Sri Dasam Granth
961d71f
@sarabveer @Harjot1Singh
feat(data): add Giani Gurbaksh Singh Gulshan publisher and update Zaf…
65ca042 
…arnama
@sarabveer @Harjot1Singh
feat(data): add Seva Singh publisher and update Kabit Savaiye
1399b7e
@sarabveer @Harjot1Singh
feat(data): add Dr. Ganda Singh publisher and update Bhai Nand Lal
2e0228b
@Harjot1Singh
build: rename sources to compilations, and publications to sources
b6acdb4 
BREAKING CHANGE: gurmukhi, first_letters, and vishraam_first_letters are now moved to the line_content table. Select gurmukhi from this table instead.

Sources are now Compilations. Use the updated model and select from this table instead.
@Harjot1Singh Harjot1Singh merged commit dfb62bf into dev Mar 18, 2020
@Harjot1Singh Harjot1Singh deleted the 1480-add-variants branch March 18, 2020 16:39
@sarabveer sarabveer mentioned this pull request Mar 19, 2020
Closed
This was referenced May 25, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhajneet bhajneet Awaiting requested review from bhajneet

@sarabveer sarabveer Awaiting requested review from sarabveer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for multiple sources for each composition
2 participants
@Harjot1Singh @sarabveer