fix(data): correct page and line numbers

[sarabveer]

Summary of PR

For SGGS, the page and line numbers were corrected according to the SGGS PDF available on SGPC.net

I made a csv file with 3 columns: id, source_page, source_line

This was then imported into the DB using the following query:

UPDATE lines
SET
	source_page = (SELECT source_page FROM fixedLines WHERE id = lines.id),
	source_line = (SELECT source_line FROM fixedLines WHERE id = lines.id) 
WHERE id IN (SELECT id FROM fixedLines)

Ideally, this would be done through #1388. I could be able to feed the bot the csv file and it could automatically commit changes.

For Sri Dasam Granth, the changes were done manually with the ones mentioned by @SSAT in #1763

Time spent on PR

nine_thousand_years

Linked issues

Fix #1763

Closes #1764
Closes #1765

[bhajneet]

Since there are files for "source_page" 156 and 157, how does json 155 contain lines that go all the way to 158?

Only other confusion I have is how source_line was figured out

[sarabveer]

Since there are files for "source_page" 156 and 157, how does json 155 contain lines that go all the way to 158?

There is only 0155.json, after that there is 0159.json

Only other confusion I have is how source_line was figured out

For which composition?

[bhajneet]

Looking at the branch it seems 156 and 157 exist:

• https://github.com/ShabadOS/database/blob/fix-page-numbers/data/Sri%20Guru%20Granth%20Sahib%20Ji/0156.json
• https://github.com/ShabadOS/database/blob/fix-page-numbers/data/Sri%20Guru%20Granth%20Sahib%20Ji/0157.json

For which composition?

Just wondering how any of them were done. E.g. programmatically/manually?

[bhajneet]

I just realized that you've used the SGGS PDF, but you've also made changes to multiple compositions. So instead, I wonder what was the procedure for Sri Dasam Granth, for instance? Was this done manually?

[sarabveer]

@bhajneet its mentioned in the PR description

[bhajneet]

How was the line number/source line obtained programmatically from a PDF? Were there newline characters or something you used?

[sarabveer]

I should clarify its a re-import of the page numbers from Kulbir S. Thind's original DB which is based on the SGPC PDF (which Thind had created as well)

As mentioned in #1763, our original source for the metadata was iGurbani.

This also raises the question if our author ids are correctly assigned.

[bhajneet]

@sarabveer please track exploration of author ids in a new issue