feat: add launch in fullscreen on startup toggle (#563)

Co-authored-by: ਸਹਜਪ੍ਰੀਤ ਸਿੰਘ <saihajpreet.singh@gmail.com> Co-authored-by: Harjot Singh <harjot@harkul.com>
shabados · Jun 29, 2020 · 466dc23 · 466dc23
1 parent e3e9963
commit 466dc23
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/app/electron/electron-wrapper.js b/app/electron/electron-wrapper.js
@@ -3,10 +3,10 @@ import { app } from 'electron'
 
 import logger from '../lib/logger'
 import { isDev } from '../lib/consts'
-
-import { createMainWindow, createNonMainWindows, closeNonMainWindows, createWindow, createSplashScreen, getMainWindow } from './window'
+import { createMainWindow, createNonMainWindows, closeNonMainWindows, createWindow, createSplashScreen, getMainWindow, getDisplayWindows } from './window'
 import { setBeta, initUpdates, checkUpdates, UPDATER_ERRORS } from './updates'
 
+
 let splashScreen
 
 app.on( 'ready', () => {
@@ -17,6 +17,12 @@ app.on( 'ready', () => {
 } )
 
 const onSettingsChange = ( { system } ) => {
+  // Fullscreen any display windows on start, if set
+  const windows = getDisplayWindows()
+  Object.values( windows ).forEach( window => window.once( 'ready-to-show', () => {
+    window.setSimpleFullScreen( system.fullscreenOnLaunch )
+  } ) )
+
   // Toggle multiple displays
   if ( system.multipleDisplays ) createNonMainWindows()
   else closeNonMainWindows()
@@ -31,7 +37,6 @@ const onServerReady = server => {
 
   // Create the main window
   createMainWindow()
-
   // Close splashscreen when the main window has been shown
   getMainWindow().once( 'show', () => splashScreen.close() )
 }

diff --git a/app/frontend/src/lib/options.js b/app/frontend/src/lib/options.js
@@ -33,6 +33,7 @@ import {
   faDesktop,
   faTags,
   faSearch,
+  faExpandArrowsAlt,
   faRemoveFormat,
 } from '@fortawesome/free-solid-svg-icons'
 import {
@@ -115,6 +116,7 @@ export const OPTIONS = {
   private: { name: 'Private Settings', icon: faLock, type: OPTION_TYPES.toggle, privacy: PRIVACY_TYPES.private },
   launchOnStartup: { name: 'Launch On Startup', icon: faDoorOpen, type: OPTION_TYPES.toggle, privacy: PRIVACY_TYPES.global },
   multipleDisplays: { name: 'All Displays', icon: faDesktop, type: OPTION_TYPES.toggle, privacy: PRIVACY_TYPES.global },
+  fullscreenOnLaunch: { name: 'Launch In Fullscreen', icon: faExpandArrowsAlt, type: OPTION_TYPES.toggle, privacy: PRIVACY_TYPES.global },
   serverAnalytics: { name: 'Server Usage Analytics', icon: faChartPie, type: OPTION_TYPES.toggle, privacy: PRIVACY_TYPES.global },
   automaticUpdates: { name: 'Automatic Updates', icon: faSync, type: OPTION_TYPES.toggle, privacy: PRIVACY_TYPES.global },
   betaOptIn: { name: 'Beta Updates', icon: faFlask, type: OPTION_TYPES.toggle, privacy: PRIVACY_TYPES.global },
@@ -272,6 +274,7 @@ export const DEFAULT_OPTIONS = {
       //! Currently not implemented
       // launchOnStartup: false,
       multipleDisplays: true,
+      fullscreenOnLaunch: false,
       serverAnalytics: true,
       automaticUpdates: true,
       betaOptIn: false,

diff --git a/app/settings.default.json b/app/settings.default.json
@@ -2,6 +2,7 @@
   "system": {
     "launchOnStartup": false,
     "multipleDisplays": true,
+    "fullscreenOnLaunch": false,
     "serverAnalytics": true,
     "automaticUpdates": true,
     "betaOptIn": false