Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text color in Hotkeys Settings page in Dark theme #279

Closed
sarabveer opened this issue Nov 8, 2019 · 1 comment · Fixed by #403
Closed

Fix text color in Hotkeys Settings page in Dark theme #279

sarabveer opened this issue Nov 8, 2019 · 1 comment · Fixed by #403
Labels
Impacts Some Affects the average end-user. Scope: Frontend/Settings ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@sarabveer
Copy link

Look at the text color of GLOBAL

image
@sarabveer sarabveer changed the title Fix text color in Hotkeys Settings page Fix text color in Hotkeys Settings page in Dark theme Nov 8, 2019
@bhajneet
Copy link
Member

bhajneet commented Feb 1, 2020

@Harjot1Singh this was fixed for overlay, but I guess it didn't affect Hotkeys?

@bhajneet bhajneet added Impacts Some Affects the average end-user. Scope: Frontend/Settings Status: Confirmed ○ Type Bug Regressions/production issues that do not function as intended. labels Feb 1, 2020
bhajneet added a commit that referenced this issue Feb 1, 2020
@bhajneet
fix(frontend/settings): color text correctly
6959995 
fixes color of title in hotkeys and translation sources

close #279
@bhajneet bhajneet mentioned this issue Feb 1, 2020
Merged
Harjot1Singh pushed a commit that referenced this issue Feb 8, 2020
@bhajneet @Harjot1Singh
fix(frontend/settings): color text correctly
e244a5c 
fixes color of title in hotkeys and translation sources

close #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impacts Some Affects the average end-user. Scope: Frontend/Settings ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend/settings): color text correctly shabados/presenter
2 participants
@sarabveer @bhajneet