Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine vishraam color toggles #371

Closed
bhajneet opened this issue Jan 13, 2020 · 1 comment · Fixed by #561
Closed

Combine vishraam color toggles #371

bhajneet opened this issue Jan 13, 2020 · 1 comment · Fixed by #561
Assignees
@bhajneet
Labels
Effort 0 Non-work/tracking. Impacts Some Affects the average end-user. Scope: Frontend/Settings □ Type Story Feature or requirement written from the user's perspective using non-technical language.

Comments

@bhajneet
Copy link
Member

Dependent on #363

If choosing to combine larrivaar for all fields, renamed to simply "larrivaar", then just group vishraam color toggles under one toggle for "Show Colors"

Related #370
@bhajneet bhajneet added Status: On Hold □ Type Story Feature or requirement written from the user's perspective using non-technical language. Impacts Some Affects the average end-user. Scope: Frontend/Settings labels Jan 13, 2020
@bhajneet
Copy link
Member Author

bhajneet commented Feb 1, 2020

Not sure what I was originally thinking, but this issue is not dependent on #363 but is related to #368

Vishraams =/= Larrivaar

@Harjot1Singh Harjot1Singh added the Effort 0 Non-work/tracking. label Feb 27, 2020
@bhajneet bhajneet self-assigned this May 28, 2020
@bhajneet bhajneet mentioned this issue May 28, 2020
Merged
Harjot1Singh pushed a commit that referenced this issue May 29, 2020
@bhajneet
feat(frontend/settings): combine vishraam color toggles (#561)
719b072 
Fixes #371
@bhajneet bhajneet mentioned this issue Jul 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhajneet bhajneet

Labels
Effort 0 Non-work/tracking. Impacts Some Affects the average end-user. Scope: Frontend/Settings □ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(frontend/settings): combine vishraam color toggles
2 participants
@Harjot1Singh @bhajneet