Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info panel's buttons need styling #492

Closed
bhajneet opened this issue May 8, 2020 · 0 comments · Fixed by #503
Closed

Info panel's buttons need styling #492

bhajneet opened this issue May 8, 2020 · 0 comments · Fixed by #503
Assignees
@saihaj
Labels
Effort 1 Simple task (code/non-code). Impacts Some Affects the average end-user. ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@bhajneet
Copy link
Member

bhajneet commented May 8, 2020

A background, border, or anything to give away the fact that it's a button to be pressed/clicked

See settings buttons, can use the same. Also related #432
@bhajneet bhajneet added Status: Confirmed ○ Type Bug Regressions/production issues that do not function as intended. Impacts Some Affects the average end-user. Effort 1 Simple task (code/non-code). labels May 8, 2020
saihaj added a commit to saihaj/ShabadOSpresenter that referenced this issue May 8, 2020
@saihaj
fix(frontend/controller): style info panel's buttons
615405b 
Uses theme variable colors for styling.

Fixes shabados#492
@saihaj saihaj mentioned this issue May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saihaj saihaj

Labels
Effort 1 Simple task (code/non-code). Impacts Some Affects the average end-user. ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI Fixes saihaj/ShabadOSpresenter
2 participants
@bhajneet @saihaj