feat(frontend/settings): theme tool #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harjot1Singh
requested changes
Jun 28, 2020
Co-authored-by: Harjot Singh <harjot@harkul.com>
saihaj
changed the title
Harjot1Singh
approved these changes
Jun 29, 2020
|
There is a very clear 2-column pattern of key & values. To have two buttons designed like this is confusing to the pattern. Please use one button per row/line. |
|
Additionally, the theme tool could just be in the Learn More button, no? Keep it simple and use the existing paradigms in place for advanced learning/usage. |
|
Should we revert this back and make the change? |
|
I’d suggest PR’ing the change (since dev isn’t a release, reverting doesn’t serve a point if we’re going to recommit). The Learn More button provides a lot of information that a user may not ever know about, and that the theme tool has no link to. So, it would make sense to still keep both buttons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Adds a button in overlay settings to link to theme tool and also changes the description.
Before
After
Time spent on PR
30 minutes
Linked issues
Fix #506
Reviewers
@Harjot1Singh