fix(frontend/settings): change theme tool button position

[saihaj]

Summary of PR

Changes position of overlay button in settings

Before

After

Time spent on PR

2 mins

Related

#583 (comment)

Reviewers

@bhajneet @Harjot1Singh

[bhajneet]

This should not have been opened for review with such a noticeable style issue.

[bhajneet]

Possibly related to #519

[saihaj]

@Harjot1Singh should I address #519 in new PR or do it here? @bhajneet is the button layout change acceptable though?

[Harjot1Singh]

It might actually make more sense to do #519 first if it won’t take too long, and merge it in

[saihaj]

@bhajneet MaterialUI Grid and Button have some sort of padding is causing the green lines as shown in your screenshot.

[bhajneet]

Can you add a css rule for sibling of button to remove it's top padding?

[saihaj]

Removing top padding doesn't help. I also tried margin but that didn't work.

That yellow region is the one that needs to be removed somehow.

[bhajneet]

Yeah, so that would be top margin then. Rule would be similar to

.MuiButtonbase-root + .MuiButtonbase-root {
  margin-top: 0;
}

[Harjot1Singh]

What is happening with this PR @saihaj?

[saihaj]

I think me and @bhajneet were trying to do something and that didn’t work. Can you please run it locally and see. I think this is what the issue is #586 (comment)

[bhajneet]

Too stale