Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible babel-eslint versions causing frontend to crash #614

Closed
bhajneet opened this issue Oct 28, 2020 · 4 comments · Fixed by #615
Closed

incompatible babel-eslint versions causing frontend to crash #614

bhajneet opened this issue Oct 28, 2020 · 4 comments · Fixed by #615
Assignees
@bhajneet
Labels
Effort 1 Simple task (code/non-code). Impacts Most Affects a majority of end-users. ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@bhajneet
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout PR fix(frontend/settings): change theme tool button position #586
  2. npm i
  3. npm start
  4. See error

Screenshots
image

@Harjot1Singh please tell me what you want me to do to fix this
@bhajneet bhajneet added Impacts Most Affects a majority of end-users. Status: To Do ○ Type Bug Regressions/production issues that do not function as intended. Effort 0 Non-work/tracking. labels Oct 28, 2020
@bhajneet bhajneet self-assigned this Oct 28, 2020
@saihaj
Copy link
Member

saihaj commented Oct 28, 2020 •
edited
Loading

Can you try merging current dev in that branch because #586 branch is outdated and this issues was fixed in #605

@bhajneet
Copy link
Member Author

That is what I did

Should I try deleting node_modules, package-lock.json etc? I'd really rather avoid all that again lol

@saihaj
Copy link
Member

saihaj commented Oct 28, 2020

Should I try deleting node_modules, package-lock.json etc?

yes please : )

@bhajneet
Copy link
Member Author

deleting node_modules and package-lock.json files did not work

uninstalling babel-eslint and re-installing it brings it up to correct version

going to commit the new package.json and package-locks

@bhajneet bhajneet added Effort 1 Simple task (code/non-code). and removed Effort 0 Non-work/tracking. labels Oct 28, 2020
@bhajneet bhajneet mentioned this issue Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhajneet bhajneet

Labels
Effort 1 Simple task (code/non-code). Impacts Most Affects a majority of end-users. ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: update package lock dependencies
2 participants
@bhajneet @saihaj