feat(frontend): add inline transliterations to presenter gurmukhi #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can be used in camps to help teach gurmukhi from it's english equivalent note: it is no longer possible to justify gurmukhi/source line (center text and primary pause wrapping continue to work fine) Fixes shabados#248
helps with readability and grouping words with their translit better
issue was introduced and now fixed in same PR
…o pr/bhajneet/607-1
…terations on the fly
…:Harjot1Singh/desktop into pr/bhajneet/607
with the introduction of inline translit, words can have different width spaces in the same word column, which would lead to staggered alignment as opposed to true centered alignment of words in the column using margin alleviates that issue by allowing words in the column to center properly and having the space between each word column be the same font size of word class is now set to gurmukhi so as to leverage the gurmukhi font size as the space sizer
|
Great work!
|
bhajneet
previously approved these changes
Nov 3, 2020
bhajneet
added
⊖ Blocked ⊖
saihaj
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOVED FROM #607
This can be used in camps to help teach gurmukhi from it's english equivalent
note: it is no longer possible to justify gurmukhi/source line (center text and primary pause wrapping continue to work fine)
This also renders transliterations on the fly, and no longer fetches them from database. This should result in a performance enhancement for loading times.
Additionally, code refactoring occurred to make the line components more maintainable and logical.
Fixes #248
Summary of PR
Tests for unexpected behavior
@Harjot1Singh tests:
Time spent on PR
Linked issues
Fix #248
Reviewers
@Harjot1Singh
Comments
I can also add a "guide" option such as "Column Lines for Inline Transliterations", it would perhaps look something like this: