Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.7.0 #522

Merged
merged 46 commits into from
May 15, 2020
Merged

Release 2.7.0 #522

merged 46 commits into from
May 15, 2020

Conversation

Harjot1Singh
Copy link
Member

No description provided.

saihaj and others added 30 commits May 8, 2020 12:40
@saihaj
fix(frontend/controller): Next/Prev line buttons on controller
5e3eb3d 
Closes #474
@saihaj
fix(frontend/controller): add spacing to info panel
cb51a1f 
fixes #493
@saihaj
fix(frontend/controller): style info panel's buttons
615405b 
Uses theme variable colors for styling.

Fixes #492
@saihaj
fix(frontend/settings): match reset button style
d630575 
Uses theme variable colors for styling.

Fixes #432
@saihaj
fix(frontend/controller): rename info panel's buttons
891826a 
> Could just be "Copy" and "Open Online" for now
<sub>Originally posted by @bhajneet [View in Slack](https://shabados.slack.com/archives/CSLLP3X32/p1588967549013200)</sub>
@saihaj
fix(frontend/controller): show disabled copy button
5a57a08 
Also refactors CSS for popover panel buttons.

Fixes #497
@saihaj
refactor(frontend/settings): two space indentations
8776f22
@saihaj
refactor(frontend/controller): two space indentations and classnames
bc63272
@saihaj
fix(frontend/settings): change import statement for button
66b25c6 
Button componenet from SettingsComponent should be used instead making a new button.
@saihaj
Merge branch 'dev' into ui-fixes
4180360
@Harjot1Singh
Merge pull request #503 from saihaj/ui-fixes
1a7e357
@saihaj @Harjot1Singh
feat(backend): get section, translation and translit data for search …
7eee164 
…results
@saihaj @Harjot1Singh
feat(frontend/controller): display metadata and translations with sea…
d80b94d 
…rch results
@saihaj @Harjot1Singh
style(fronted/controller): result list similar to mockup from mobile
eed3ad3
@bhajneet @Harjot1Singh
fix(frontend/controller): use css font declaration instead of font we…
1fe6a8f 
…ight for gurmukhi
@bhajneet @Harjot1Singh
feat(frontend/controller): re-order search result fields for readability
5826ab9 
- use non-location based css names
- use opacity for theme compatibility
@bhajneet @Harjot1Singh
feat(frontend/controller): widen list items for readability and touch…
a01dcc0 
…-friendliness
@bhajneet @Harjot1Singh
feat(frontend/controller): add source to search result citation
8fed3b2
@bhajneet @Harjot1Singh
fix(frontend/controller): fix css formatting of citation and refactor…
ba74d4e 
… font sizes
@bhajneet @Harjot1Singh
fix(frontend/controller): render final italic parenthesis correctly
31554bb
@saihaj @Harjot1Singh
feat(frontend/settings): add settings options for search results
beddee1 
make a new subsection called activites.

Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
feat(frontend/controller): highlight translits for search results
4e29296
@saihaj @Harjot1Singh
fix(frontend/settings): server and other partially dynamic settings
b3199cf 
Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
feat(frontend): add constants for mapping back class names from langu…
b976539 
…age ID's

Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
feat(frontend): add constants for source abbreviations
cde1730 
will be removed once shabados/database#1767 is resolved

Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
reactor(frontend/presenter): use constants to map class names
82870cd 
related to c445675

Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
refactor(frontend/overlay): use constants to map class names
2a8313d 
related to c445675

Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
fix(frontend/settings): server and other partially dynamic settings
5da6dae 
related to 223df6e

Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
refactor(frontend): use constants for language ID and rename search r…
943780a 
…esult options

Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
feat(frontend/controller): integrate with search result options
cf95ba5 
Co-Authored-By: Harjot Singh <contact@harjot.me>
saihaj and others added 11 commits May 15, 2020 01:59
@saihaj @Harjot1Singh
style(frontend/controller): add fonts for different languages
05b0567 
Co-Authored-By: Harjot Singh <contact@harjot.me>
@saihaj @Harjot1Singh
fix(frontend): change defaults for serach results options
f4d4a42
@saihaj @Harjot1Singh
fix(frontend): short source name
0230e8b 
Two words for Bhai Nand Laal compositions as per source.

Related: #510 (comment)
@saihaj @Harjot1Singh
fix(frontend/settings): Display "none" instead of "Off" in serach res…
82979a6 
…ults settings
@saihaj @Harjot1Singh
fix(frontend): rename "show metadata" option and rearrange the order
87139d7
@saihaj @Harjot1Singh
fix(frontend): rename "Show metadata"
b68faea 
related to 2730ac9
@saihaj @Harjot1Singh
fix(frontend/controller): full-word search issue
031a072
@Harjot1Singh
perf: only return translations, transliteration, citations if setting…
2ebc5b5 
…s are enabled
@Harjot1Singh
fix(frontend/settings): use category name from settings as title
6cf79e3
@bhajneet
docs: add v2.7.0 release notes (#520)
274b545
@Harjot1Singh
build: bump to 2.7.0
b9b4932
@lgtm-com
Copy link

lgtm-com bot commented May 15, 2020

This pull request introduces 1 alert when merging b9b4932 into dd0ff5d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@bhajneet bhajneet self-requested a review May 15, 2020 13:58
@bhajneet
Copy link
Member

Getting this error in browser:
image

@saihaj
Copy link
Member

saihaj commented May 15, 2020

I would suggest clearing out local storage and then run it. If it crashes then we should investigate further. Reason with dev is that localhost is the domain that is used and localstorage has so many things in it as theme-tool also uses it and never gets flushed out properly

@bhajneet
Copy link
Member

Fix the linting and release is good to go.

Need to resolve punjabi fonts and incorrect citation formatting for next release.

Our list of fixes keeps growing with every new feature implementation. So our next release will strongly focus on severely cutting down our existing fix list before tackling any new features. This is imperative. Discussion and development of new features are to be ceased until Q is empty of bug fixes.

@saihaj
Copy link
Member

saihaj commented May 15, 2020

#527 should fix lining errors

@Harjot1Singh Harjot1Singh merged commit 01182b9 into master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhajneet bhajneet Awaiting requested review from bhajneet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harjot1Singh @bhajneet @saihaj