Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend/controller): change default citation format #576

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Jun 2, 2020

Summary of PR

Change the citation format to hyphenated (BOS style)

Tests for unexpected behavior

Before:
Screen Shot 2020-06-02 at 9 48 23 AM

After:
image

Time spent on PR

5 minutes -> 30 seconds for fix and remaining for opening issue and PR

Linked issues

Fix #575

Reviewers

@bhajneet @Harjot1Singh

@saihaj saihaj requested a review from Harjot1Singh June 2, 2020 15:40
Copy link
Member

@bhajneet bhajneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harjot1Singh Harjot1Singh merged commit 7f5ced3 into shabados:dev Jun 2, 2020
@saihaj saihaj deleted the default-citation-format branch June 2, 2020 16:06
saihaj added a commit to saihaj/ShabadOSpresenter that referenced this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default citation format
3 participants