fix: update cmdk breaking changes #3268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ObjectJosh is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
ScottyMaher
approved these changes
Mar 31, 2024
|
thanks you @ObjectJosh. Tried your proposed changes on my little project, works nicely for my usecase. |
darrenswhite
reviewed
Apr 5, 2024
| @@ -81,26 +82,28 @@ export function ComboboxDemo() { | |||
| <Command> | |||
| <CommandInput placeholder="Search framework..." /> | |||
| <CommandEmpty>No framework found.</CommandEmpty> | |||
There was a problem hiding this comment.
I think CommandEmpty should be inside CommandList
| @@ -64,26 +65,28 @@ export default function ComboboxDemo() { | |||
| <Command> | |||
| <CommandInput placeholder="Search framework..." /> | |||
| <CommandEmpty>No framework found.</CommandEmpty> | |||
2 tasks
|
👋 Thanks for making the changes! |
@coolbaluk Currently waiting for it to get merged. Not sure if the proposed changes above by @darrenswhite ar e correct. Would like a second opinion, thanks. |
|
5013
shadcn ***@***.***> schrieb am Mo., 5. Aug. 2024, 12:22:
… Closed #3268 <#3268>.
—
Reply to this email directly, view it on GitHub
<#3268 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIO77COUUYPFIKLZDPEGARDZP5G7TAVCNFSM6AAAAABFPAOUBSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG43DEMBSGE2DKNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
cmdkv1.0.0 released some breaking changesThis PR fixes @shadcn's usage of
cmdk's Command component for the shadcn Combobox component.cmdkv0.2.1 -> v1.0.0data-[selected=true](see release notes above)Fixes #3213 #3051 #3047 #3024 #3021 #3012 #2944 #3256
Before:
After: