-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quick fix to data attribute at CommandPrimitive.Item that was applying a disabled state style all the time #3680
fix: quick fix to data attribute at CommandPrimitive.Item that was applying a disabled state style all the time #3680
Conversation
applying a disabled state style all the time
@ricardoraposo is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Hello @ricardoraposo, I had the same problem and fixed it the same way. Thank you for your Pull Request, it allowed me to be sure that my fix was correct. |
@shadcn u need to review this PR |
Thank you so much. I was struggling with this too until I saw your PR |
+1 for this PR. I had the same issue and this change fixed it. |
@ricardoraposo thankkkssss .. ui -> command.tsx -> [search] CommandPrimitive.Item -> [Copy Paste] |
thanks so much @ricardoraposo, @shadcn please review this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
…plying a disabled state style all the time (shadcn-ui#3680) Data attributes at <CommandPrimite.List /> component should be written as data-[disabled=true] in order to avoid styles being applied to element, even when it's not disabled.
Data attributes at <CommandPrimite.List /> component should be written as data-[disabled=true] in order to avoid styles being applied to element, even when it's not disabled.