Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps): Update lodash #4397

Merged
merged 13 commits into from
Dec 9, 2024
Merged

Conversation

JensAstrup
Copy link
Contributor

Background

There is currently a vulnerability in lodash.template that is of high severity which this repository relies on. No update has been made on their end and the project was last updated 5 years ago.

Solution

In order to resolve the vulnerability I replaced lodash.template with the current version of lodash and replaced usages of import template from "lodash.template" with import { template } from "lodash" which should achieve the same functionality

Closes #3978

Copy link

vercel bot commented Jul 23, 2024

@JensAstrup is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@DominikScholz
Copy link

would be great if this could be merged in

@alexsilvar
Copy link

Any idea about what is missing to merge it?

@JensAstrup
Copy link
Contributor Author

I have no idea who I'm waiting on or what the next step is, unless I'm missing something from CONTRIBUTING.md, I'm fairly certain I've done everything. @shadcn Any assistance here? 🥺

@MoSheikh
Copy link

Would also appreciate it if maintainers could take a look. Thank you!

@jaxazam
Copy link

jaxazam commented Oct 3, 2024

Thanks for the work @JensAstrup.ave you heard back from them through any other channels? I'm guessing not...

@JensAstrup
Copy link
Contributor Author

No, haven't heard anything yet :/

@alexsilvar
Copy link

Please expedite this PR

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

No update has been made on their end and the project was last updated 5 years ago.

I was surprised to read this but it's true.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Dec 9, 2024 8:55am

@JensAstrup
Copy link
Contributor Author

@shadcn Way more checks were run after that merge, I assume that has to do with the failing Vercel build? I'll take a look into the others 👀

@gdragotto
Copy link

The lock file seems out of date @JensAstrup

 ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY  Broken lockfile: no entry for 'lodash.template@4.5.0' in pnpm-lock.yaml

Can you try

pnpm install --no-frozen-lockfile?

@BowTiedFirefox
Copy link

is there an update or we can jump in to help?

@BowTiedLaplace
Copy link

Please fix this asap.

@shadcn shadcn self-assigned this Nov 20, 2024
@shadcn shadcn added the area: roadmap This looks great. We'll add it to the roadmap, review and merge. label Nov 20, 2024
@gdragotto
Copy link

@shadcn can we help? It should be a simple fix in the CI

@dandubya
Copy link

dandubya commented Dec 7, 2024

Same urgency here. Thank you.

@shadcn shadcn merged commit a1bed46 into shadcn-ui:main Dec 9, 2024
6 checks passed
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
* chore(apps): Refactor usage of lodash.template to lodash to address security vulnerability

* chore(cli): Refactor usage of lodash.template to lodash to address security vulnerability

* deps: update lock

* chore: changesets

* style: fix format

* fix: import

* chore: build registry

---------

Co-authored-by: shadcn <m@shadcn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: roadmap This looks great. We'll add it to the roadmap, review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: There is a vulnerability in shadcn-ui@0.8.0 > lodash.template@4.5.0
10 participants