fix(shadcn): default next styles are not completely cleared

[sapenlei]

after initializing nextjs project, the global css is

after initializing shadcn , the global css is

--foreground, --background of nextjs conflict with shadcn. nextjs will override shadcn.

Fix #4923

[vercel]

@sapenlei is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

[shadcn]

This is intentional. We use different tokens from default Next.js. Is this an issue?

[sapenlei]

This is intentional. We use different tokens from default Next.js. Is this an issue?

The tokens for previous versions of nextjs were different, but the current ones are the same

[sapenlei]

This is intentional. We use different tokens from default Next.js. Is this an issue?

After nextjs version 14.2.7, the background and foreground tokens of global css changed and became the same as those of shadcn

[Jacksonmills]

idk if it helps but I just spun up a new next app with shadcn@latest init to test this as I was hitting some weirdness and had to do a little refactor in a separate project.

specifically noticed this when setting up themes using the class based approach, easy enough to just delete the lines and then the usual set up worked just fine

seems these lines do override the shadcn base variables:

:root {
  --background: #ffffff;
  --foreground: #171717;
}

@media (prefers-color-scheme: dark) {
  :root {
    --background: #0a0a0a;
    --foreground: #ededed;
  }
}

some screenshots:

[Jacksonmills]

This is intentional. We use different tokens from default Next.js. Is this an issue?

The tokens for previous versions of nextjs were different, but the current ones are the same

vercel/next.js@c0b3f43

[shadcn]

@Jacksonmills you're right. @sapenlei I also misread the PR title. I thought you meant we should not override. I'll review and merge. Thank you both.

[shadcn]

All good. Thank you.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
ui	⬜️ Ignored (Inspect)	Visit Preview	Sep 23, 2024 7:38am