Skip to content

Commit

Permalink
Address minor compiler warnings
Browse files Browse the repository at this point in the history
    copydir.c:666:44: warning: unsigned conversion from 'int' to '__mode_t' {aka 'unsigned int'} changes value from '-4096' to '4294963200' [-Wsign-conversion]
      666 |         if (   (mknod (dst, statp->st_mode & ~07777, statp->st_rdev) != 0)
          |                                            ^

    copydir.c:116:1: warning: missing initializer for field 'quote' of 'struct error_context' [-Wmissing-field-initializers]
      116 | };
          | ^
    In file included from copydir.c:27:
    /usr/include/attr/error_context.h:30:23: note: 'quote' declared here
       30 |         const char *(*quote) (struct error_context *, const char *);
          |                       ^~~~~
  • Loading branch information
cgzones authored and hallyn committed Aug 17, 2022
1 parent f606314 commit 6cbec2d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions libmisc/copydir.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ static void error_acl (unused struct error_context *ctx, const char *fmt, ...)
}

static struct error_context ctx = {
error_acl
error_acl, NULL, NULL
};
#endif /* WITH_ACL || WITH_ATTR */

Expand Down Expand Up @@ -663,7 +663,7 @@ static int copy_special (const char *src, const char *dst,
}
#endif /* WITH_SELINUX */

if ( (mknod (dst, statp->st_mode & ~07777, statp->st_rdev) != 0)
if ( (mknod (dst, statp->st_mode & ~07777U, statp->st_rdev) != 0)
|| (chown_if_needed (dst, statp,
old_uid, new_uid, old_gid, new_gid) != 0)
#ifdef WITH_ACL
Expand Down

0 comments on commit 6cbec2d

Please sign in to comment.