Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prog and shadow_logfd should not be extern variables #444

Closed
rbalint opened this issue Nov 14, 2021 · 1 comment · Fixed by #471
Closed

Prog and shadow_logfd should not be extern variables #444

rbalint opened this issue Nov 14, 2021 · 1 comment · Fixed by #471
Assignees
@hallyn

Comments

@rbalint
Copy link
Contributor

rbalint commented Nov 14, 2021

They should be provided via function calls to the logging API . This would solve the messy situation with linking.
@hallyn
Copy link
Member

hallyn commented Nov 27, 2021

Yeah I've been meaning to try something along those lines. Thanks.

@hallyn hallyn self-assigned this Nov 27, 2021
hallyn added a commit to hallyn/shadow that referenced this issue Nov 29, 2021
@hallyn
[wip] Make shadow_logfd and Prog not extern
25d1aba 
Closes shadow-maint#444

Signed-off-by: Serge Hallyn <serge@hallyn.com>
@rbalint rbalint mentioned this issue Dec 23, 2021
Closed
hallyn added a commit to hallyn/shadow that referenced this issue Dec 23, 2021
@hallyn
Make shadow_logfd and Prog not extern
222f859 
Closes shadow-maint#444

Signed-off-by: Serge Hallyn <serge@hallyn.com>
@hallyn hallyn mentioned this issue Dec 23, 2021
Merged
hallyn added a commit to hallyn/shadow that referenced this issue Dec 23, 2021
@hallyn
Make shadow_logfd and Prog not extern
79157cb 
Closes shadow-maint#444
Closes shadow-maint#465

Signed-off-by: Serge Hallyn <serge@hallyn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallyn hallyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make shadow_logfd and Prog not extern hallyn/shadow
2 participants
@hallyn @rbalint