Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac, lib/, src/: Assume setgroups(2) and initgroups(3) exist #1125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Nov 16, 2024

They're available in every system I checked: glibc,musl,{Free,Net,Open}BSD.


Revisions:

v1b
  • Rebase
$ git range-diff master..gh/setgroups shadow/master..setgroups 
1:  878f9ea6 = 1:  5fdcd89b configure.ac, lib/, src/: Assume setgroups(2) exists
2:  0270f587 = 2:  ee242d98 configure.ac, lib/: Assume initgroups(3) exists
v1c
  • Rebase
$ git range-diff master..gh/setgroups shadow/master..setgroups 
1:  5fdcd89b = 1:  c6790b27 configure.ac, lib/, src/: Assume setgroups(2) exists
2:  ee242d98 = 2:  6518b23c configure.ac, lib/: Assume initgroups(3) exists
v1d
  • Rebase
$ git range-diff master..gh/setgroups shadow/master..setgroups 
1:  c6790b27 ! 1:  d4be5ef8 configure.ac, lib/, src/: Assume setgroups(2) exists
    @@ lib/addgrps.c
      
      #include "prototypes.h"
      #include "defines.h"
    -@@ lib/addgrps.c: int add_groups (const char *list)
    +@@ lib/addgrps.c: add_groups(const char *list)
        free (grouplist);
        return 0;
      }
2:  6518b23c = 2:  8919d4a4 configure.ac, lib/: Assume initgroups(3) exists
v1e
  • Rebase
$ git range-diff master..gh/setgroups shadow/master..setgroups 
1:  d4be5ef8 = 1:  b473327a configure.ac, lib/, src/: Assume setgroups(2) exists
2:  8919d4a4 = 2:  76f9d512 configure.ac, lib/: Assume initgroups(3) exists
v1f
  • Rebase
$ git range-diff master..gh/setgroups shadow/master..setgroups 
1:  b473327a = 1:  e5ecbf64 configure.ac, lib/, src/: Assume setgroups(2) exists
2:  76f9d512 = 2:  8c555adc configure.ac, lib/: Assume initgroups(3) exists

@alejandro-colomar alejandro-colomar changed the title configure.ac, lib/, src/: Assume setgroups(2) exists configure.ac, lib/, src/: Assume setgroups(2) and initgroups(3) exist Nov 16, 2024
@alejandro-colomar alejandro-colomar force-pushed the setgroups branch 4 times, most recently from 8919d4a to 76f9d51 Compare December 6, 2024 12:07
@alejandro-colomar
Copy link
Collaborator Author

Queued after the release of 4.17.0.

@alejandro-colomar alejandro-colomar marked this pull request as draft December 6, 2024 12:16
It's available in every system I checked: glibc,musl,{Free,Net,Open}BSD.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
It's available in every system I checked: glibc,musl,{Free,Net,Open}BSD.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
@alejandro-colomar alejandro-colomar marked this pull request as ready for review December 22, 2024 12:05
@alejandro-colomar alejandro-colomar added the Simpler A good issue for a new beginner label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simpler A good issue for a new beginner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant