contrib/, lib/, src/: Use streq() instead of its pattern #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
streq
branch
from
a5a0a56 to
4ebd168
Compare
Except for the added (and sorted) includes, and the removal of redundant parentheses, this patch can be approximated with the following semantic patch: $ cat ~/tmp/spatch/streq.sp; @@ expression a, b; @@ - strcmp(a, b) == 0 + streq(a, b) @@ expression a, b; @@ - 0 == strcmp(a, b) + streq(a, b) @@ expression a, b; @@ - !strcmp(a, b) + streq(a, b) $ find contrib/ lib* src/ -type f \ | xargs spatch --sp-file ~/tmp/spatch/streq.sp --in-place; $ git restore lib/string/strcmp/streq.h; Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
streq
branch
from
4ebd168 to
10fea15
Compare
Except for the added (and sorted) includes, and the removal of redundant parentheses, and one special case, this patch can be approximated with the following semantic patch: $ cat ~/tmp/spatch/strneq.sp; @@ expression a, b; @@ - strcmp(a, b) != 0 + !streq(a, b) @@ expression a, b; @@ - 0 != strcmp(a, b) + !streq(a, b) $ find contrib/ lib* src/ -type f \ | xargs spatch --sp-file ~/tmp/spatch/strneq.sp --in-place; Signed-off-by: Alejandro Colomar <alx@kernel.org>
hallyn
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for the added (and sorted) includes, and the removal of redundant parentheses, this patch can be approximated with the following semantic patch:
Revisions:
v2
!streq()instead of its pattern.