CI: avoid cancelling all jobs when one fails #1130
Conversation
If a job in a matrix fails we don't want to cancel all jobs, thus we need to set `fail-fast: false` as a strategy property. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
|
In #1131 Alpine build was supposed to fail due to https://gitlab.alpinelinux.org/alpine/aports/-/issues/16633, but apparently it was fixed and deployed before I was able to finish my work |
|
That would increase the load, and probably slow down CI. Since such bugs are rare, I suggest manually triggering the canceled jobs, which can be done easily. On the other hand, if you think the increased load is not problematic, I don't have a strong opinion, so I'm okay if you want it. |
|
Self correction: Github has a bug, and while it supposedly allows enabling the job manually, it gets immediately canceled again if there's another job that has failed. So, we need your patch. |
If I remember correctly Github offers 20 runners per organization. In our case we need 9 runners every time the actions are triggered and they take less than 10 minutes to run, so yes, I think it's fine. |
If a job in a matrix fails we don't want to cancel all jobs, thus we need to set
fail-fast: falseas a strategy property.