fields #1150
Draft
fields #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
fields
branch
from
8bc3413 to
f3f2918
Compare
While at it, rename the function parameter. Signed-off-by: Alejandro Colomar <alx@kernel.org>
This makes these APIs more consistent with the ones for groups, which strdup(3) memory as necessary. It also makes the code simpler. Signed-off-by: Alejandro Colomar <alx@kernel.org>
Call it 'dup', which reminds that it's a strdup(3)d string. Signed-off-by: Alejandro Colomar <alx@kernel.org>
Just like the other sget*ent() functions do. Signed-off-by: Alejandro Colomar <alx@kernel.org>
For consistency, use 'fields[]' in all these functions, and don't make it unnecessarily 'static'. Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
fields
branch
from
f3f2918 to
c7c6e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming consistency.
Queued after (based on) #1146.