chage: Drop PAM support #1184
Merged
chage: Drop PAM support #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
approved these changes
Jan 14, 2025
The PAM support was only enabled with configure option --enable-account-tools-setuid. The other account tools would use PAM then to verify that the user is granted elevated permissions for actions which normally only root can do. In chage, however, any non-root user who does not specify the -l command line option is denied access in check_perms. The check for being root or not is done with getuid, so non-root users cannot change user account's aging information in any possible way since more than 18 years by now. It's safe to say that nobody misses this non-existing feature. Biggest benefit is to get chage out of the ACCT_TOOLS_SETUID group of tools. Reviewed-by: Alejandro Colomar <alx@kernel.org> Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PAM support was only enabled with configure option
--enable-account-tools-setuid. The other account tools would use PAM then to verify that the user is granted elevated permissions for actions which normally only root can do.In chage, however, any non-root user who does not specify the
-lcommand line option is denied access incheck_perms. The check for being root or not is done withgetuid, so non-root users cannot change user account's aging information in any possible way since more than 18 years by now.It's safe to say that nobody misses this non-existing feature. Biggest benefit is to get chage out of the ACCT_TOOLS_SETUID group of tools.