Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are legitimate cases where one might want to use the current host
in "peers". In particular our tests do this by using "localhost"; this
usually works because the hostname returned by
gethostname
is the~unique name of the host, so doesn't match "localhost".
In some environments, though,
gethostname
can return "localhost",which causes the peer to get filtered out. Notably this includes nix
build environments, which intentionally avoid letting global unique
state into the environment, since it would make the build
non-reproducible.
I'm not sure what problem this check was originally trying to solve. If we want to keep the safeguard some alternative options are:
gethostname
could a different name for the host than used in the config.