-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onionperf updates #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have two options for the README:
- We can just move
doc/Tools-Setup.md
totools/README
rather than copy it. That way we can avoid having two copies of that file and accidentally updating the incorrect version. If we do this approach, then we'll have to update the link in the tgen top-level README file which currently points todoc/Tools-Setup.md
.
or
- Just create a minimal README with no content other than a link to the Github
doc/Tools-Setup.md
file. That way all documentation can remain in the docs directory.
Do you have a preference?
The other code changes seem OK to me, but I didn't test it on any actual TGen output. The continuous integration does some amount of testing though, and I assume you tested on OnionPerf output to make sure it meets your needs.
Many thanks for your comments! I like the idea of having a stand-alone README page in the tgentools directory, so I'd go with Option 1. With regards to the TGen output, I've spotted another bug where the times in the output would appear in reverse order for very small transfers, and have pushed one more commit. Everything else looks good, we can always open another PR in case we spot anything during testing. Thank you very much for your help! |
OK great! Would you be able to add a commit that moves (I could do it, but since I can't push to your branch I would have to open a new PR. It would be nice to keep all of the discussion and changes on this PR.) Thank you! |
Thank you so much for the quick reply! I've made the changes and pushed the final commit! |
Hi! Here is a merge request that helps us use tgentools with onionperf. I've tried to integrate the main changes we made to the OP parser. Here is a summary:
Thank you very much for your help!