Fix #2458 Unexpected delete server behavior (#2459)

* Fix shadowsocks/shadowsocks-windows/#2458 * Servers List Box position adjustment is consistent with the v4.1.6 version
shadowsocks · Jul 14, 2019 · b708927 · b708927
1 parent 72678c4
commit b708927
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/shadowsocks-csharp/View/ConfigForm.cs b/shadowsocks-csharp/View/ConfigForm.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Drawing;
-using System.Runtime.CompilerServices;
 using System.Windows.Forms;
 using Shadowsocks.Controller;
 using Shadowsocks.Model;
@@ -89,12 +88,6 @@ private void ConfigValueChanged(object sender, EventArgs e)
             ApplyButton.Enabled = true;
         }
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        private void UpdateIndexToEnd()
-        {
-            _lastSelectedIndex = (ServersListBox.SelectedIndex = (_modifiedConfiguration.configs.Count - 1));
-        }
-
         private bool ValidateAndSaveSelectedServerDetails(bool isSave = false, bool isCopy = false)
         {
             try
@@ -157,8 +150,11 @@ private bool GetServerDetailsFromUI(out Server server, bool isSave = false, bool
                 _modifiedConfiguration.configs.RemoveAt(_lastSelectedIndex);
                 ServersListBox.SelectedIndexChanged -= ServersListBox_SelectedIndexChanged;
 
+                int lastIndex = ServersListBox.SelectedIndex;
+
                 LoadServerNameListToUI(_modifiedConfiguration);
-                UpdateIndexToEnd();
+
+                _lastSelectedIndex = (ServersListBox.SelectedIndex = lastIndex);
 
                 ServersListBox.SelectedIndexChanged += ServersListBox_SelectedIndexChanged;
                 return true;
@@ -453,7 +449,7 @@ private void AddButton_Click(object sender, EventArgs e)
             {
                 Configuration.AddDefaultServerOrServer(_modifiedConfiguration);
                 LoadServerNameListToUI(_modifiedConfiguration);
-                UpdateIndexToEnd();
+                _lastSelectedIndex = (ServersListBox.SelectedIndex = _modifiedConfiguration.configs.Count - 1);
             }
         }
 
@@ -462,9 +458,9 @@ private void DuplicateButton_Click(object sender, EventArgs e)
             if (ValidateAndSaveSelectedServerDetails(isCopy: true))
             {
                 Server currServer = _modifiedConfiguration.configs[_lastSelectedIndex];
-                Configuration.AddDefaultServerOrServer(_modifiedConfiguration, currServer);
+                Configuration.AddDefaultServerOrServer(_modifiedConfiguration, currServer, _lastSelectedIndex + 1);
                 LoadServerNameListToUI(_modifiedConfiguration);
-                UpdateIndexToEnd();
+                _lastSelectedIndex = (ServersListBox.SelectedIndex = (_lastSelectedIndex + 1));
             }
         }
 
@@ -478,7 +474,11 @@ private void DeleteButton_Click(object sender, EventArgs e)
             }
 
             LoadServerNameListToUI(_modifiedConfiguration);
-            UpdateIndexToEnd();
+            ServersListBox.SelectedIndexChanged -= ServersListBox_SelectedIndexChanged;
+
+            _lastSelectedIndex = (ServersListBox.SelectedIndex = (_lastSelectedIndex >= _modifiedConfiguration.configs.Count ? (_modifiedConfiguration.configs.Count - 1) : _lastSelectedIndex));
+
+            ServersListBox.SelectedIndexChanged += ServersListBox_SelectedIndexChanged;
             LoadSelectedServerDetails();
 
             UpdateButtons();