Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MD5 hash instead of timestamp for PAC URL #2705

Merged
4 commits merged into from Dec 16, 2019
Merged

Use MD5 hash instead of timestamp for PAC URL #2705

4 commits merged into from Dec 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

在PAC URL中改用MD5哈希替代时间戳,仅在PAC内容变化时产生新的URL参数。

@ghost
Copy link
Author

ghost commented Nov 28, 2019

#1979 #2208

这个改动有点激进需要更多测试。

EDIT: 激进程度和#2208 差不多。#1979 中的问题算不上是完全修复,当前方案仍然会在不必要的情况下生成新的URL。

相比之下少监视一个文件,在每次重启程序时生成新的secret。

@ghost ghost requested a review from celeron533 December 15, 2019 14:05
@celeron533
Copy link
Contributor

不算激进,反而能免掉一些不必要的更新

@ghost ghost merged commit 2684c44 into shadowsocks:master Dec 16, 2019
@ghost ghost deleted the pacurl-hash branch December 17, 2019 05:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant